-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken @import errors with the ember-cli-jquery-ui addon #8
Comments
does this happen with a basic app, or does it require something special? Can you provide a reduced application that demonstrate this, as it will aide in debugging. |
very easy to reproduce...
|
@eibrahim thank you |
I'm seeing this as well, started happening this morning. |
So can I keep 1.1 and set relativeTo = assets |
No, that won't work. |
var app = new EmberApp(defaults, {
minifyCSS: {
options: {
processImport: false
}
}
}); Should solve/workaround this in the meantime, but I suspect as more people upgrade to 2.3.0 this will reported on more and more. It looks like the guard which allowed for swallowing of errors, and was enabled by default, was removed which introduced the issue, but it should have been treated as an API breaking change. I've sent PRs in to resolve the issue. |
ember-cli/ember-cli-preprocess-registry#8 This is a breaking change for clean-css-promise, so not sure how to handle this but this will fix broccoli-clean-css's semver break in 1.1.0
The processImport workaround worked for me and I was able to build with the production flag. But wouldn't that break the CSS? If a css import abc.css and we tell it not to process it, does that mean abc.css will not be part of the final css? |
@eibrahim clean-css is used for minifying. You likely are using a preprocessor like LESS or SaSS to handle imports. |
I'm having the same problem. Any solutions? |
We're having the same problem. |
Having same problem. Any updates? |
Closing for now (let me know if that does not address folks' issue). |
I am getting the broken @import errors with the ember-cli-jquery-ui addon after upgrading to ember 2.3.0. The only way I was able to make my build work was to add
ember-cli-build.js
But obviously this turns off my CSS minification... Any idea what is going on?
The full error is:
by the way
ember build
works butember build --environment production
breaks which I guess comes back to minifyCSS.enabled = true#6
The text was updated successfully, but these errors were encountered: