-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v1.2.0 #6
Comments
It seems that the update has broken Ember CLI test. I just ran it locally.
|
@shinnn anything come to mind? (im on vacation so i haven't had a chance to dig in myself yet) |
I dug into it a little bit, it seems that |
Here is a hacky way to pass that test. It's ugly but it works though 😈 preprocessors.js | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/preprocessors.js b/preprocessors.js
index 936ff76..64f4d83 100644
--- a/preprocessors.js
+++ b/preprocessors.js
@@ -115,6 +115,11 @@ module.exports.preprocessMinifyCss = function(tree, options) {
if (plugins.length === 0) {
var compiler = require('broccoli-clean-css');
+ var oriRelativeTo = options.relativeTo;
+ Object.defineProperty(options, 'relativeTo', {
+ get: () => oriRelativeTo,
+ set: () => undefined
+ });
return compiler(tree, options);
} else if (plugins.length > 1) {
throw new Error('You cannot use more than one minify-css plugin at once.'); It works by preventing |
I just tested this again, and the tests all seem to be passing. @stefanpenner - If you can give me access to publish, I'll release 1.2.0 and watch for any fallout (unpublishing if needed)... |
I published 1.2.0 and I was wrong about it not being an issue anymore 😢. However, the issue is with ember-cli not broccoli-clean-css. broccoli-clean-css is ensuring that In order to allow the tests to pass in ember-cli, we need to change the default value of Since this is not a compatible change (broccoli-clean-css bumped major versions to allow for this change), I have unpublished 1.2.0 from NPM (existing/older ember-cli's cannot use the updated broccoli-clean-css without changing |
I updated ember-cli/ember-cli#5463 with the |
Builds passed when using the correct Released as v2.0.0 and updating in ember-cli in ember-cli/ember-cli#5463. |
I am getting the broken @import errors with the ember-cli-jquery-ui addon... The only way I was able to make my build work was to add
But obviously this turns off my CSS minification... Any idea what is going on? The full error is:
|
by the way |
@eibrahim let me recommend you open a new issue, and link back to this one. |
The text was updated successfully, but these errors were encountered: