-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated tests for mixin use the wrong path when the recipe is used in addons #4803
Comments
Just came across this, it's because the mixin isn't re-exported in the app folder like other blueprints are. |
Well, I don't think the addon needs to re-export the mixin. That makes sense for other types of objects, but IMO, it's better it the consumer |
Confirm, it should be imported from |
Thanks. PR coming |
Agreed. I didn't mean to imply we should, just that that was probably a copy paste issue of this test blueprint. |
Makes sense. Thanks for clarifying. |
…npenner Mixin generation in addon Fixes #4803
Steps to reproduce
ember g mixin sample
ember test
Expected:
Actual:
dummy/mixins/sample
imported from `dummy/tests/unit/mixins/sample-test".The import statement used is
import SampleMixin from '../../../mixins/sample';
When replaced withimport SampleMixin from 'ember-addon/mixins/sample';
it works.I could fix it by simply using modulePrefix on the import path, but I want to make sure I'm considering everything.
The text was updated successfully, but these errors were encountered: