Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin generation in addon #5388

Merged
merged 1 commit into from Jan 22, 2016

Conversation

MiguelMadero
Copy link
Contributor

Fixes #4803

@@ -5,7 +5,8 @@ var testInfo = require('ember-cli-test-info');
module.exports = {
description: 'Generates a mixin unit test.',
locals: function(options) {
return {
return {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation got screwy here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. argh tabs vs spaces... I had the wrong setting on this new computer.

@rwjblue
Copy link
Member

rwjblue commented Jan 22, 2016

LGTM

@stefanpenner
Copy link
Contributor

👍

@stefanpenner
Copy link
Contributor

@homu r+

@homu
Copy link
Contributor

homu commented Jan 22, 2016

📌 Commit 4fabb4b has been approved by stefanpenner

homu added a commit that referenced this pull request Jan 22, 2016
@homu
Copy link
Contributor

homu commented Jan 22, 2016

⌛ Testing commit 4fabb4b with merge 88adc1b...

@homu
Copy link
Contributor

homu commented Jan 22, 2016

☀️ Test successful - status

@homu homu merged commit 4fabb4b into ember-cli:master Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants