-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember test --server
stops building and refreshing the browser after a while
#9333
Comments
I've been noticing this too recently, but haven't found any reproducible steps. |
Does this happen when completely idle (like start |
@rwjblue I am not sure but can verify. I also wanted to point something else out Turns out it was not, I added it to our base setup and it seems to solve the issue for me so far. I can also try to repo the cold build case that you are asking about without having watchman installed. |
Ya that sounds great, thank you @ghedamat! |
We've also been seeing this a large amount at Intercom. It's actually been happening for a fairly long time. We've an internal issue open to look into it since the beginning of 2020 😬 I did some digging and it seems to have something to do with some code in Testem where it will stop trying to connect to the browser (and therefore reloads) if it hits the threshold of the To try and reproduce I followed the following process:
See the testem logs generated below:
Testem logs showing reconnection limit being reached, i.e.
|
I've been experiencing this issue chronically for the past year or so. Using |
Hmm, could this be due to the issue that @brendenpalmer fixed in broccolijs/broccoli-concat#156? That bug was very very difficult to diagnose, but basically caused concat to ignore changes to files over the 10000 char limit in specific contexts. This makes it appear that rebuilds are happening but the new content is never served. Can y'all check what version of broccoli-concat is being used (and if possible force it to 4.2.5)? |
(responding on behalf of @ghedamat ): 4.2.4. I'll see if we can bump. |
We're also on 4.2.4 in all of our apps. I'll bump to 4.2.5 and test it out next time I'm using For the time being, I can workaround the issue by bumping up some testem config values to large numbers:
|
Initial investigation suggest that 4.2.5 does not resolve this problem. |
Drats, sorry folks. If the issues is indeed with testem configuration, we can update the default blueprint to use those settings... |
Yep I've found increasing the |
I have noticed this behaviour for years, perhaps since Ember.js v3.8. |
I notice this most often when I try to filter or apply a specific test module. I can't recall seeing it any other way. |
Anyone find an issue over the years? |
we're in the process of switching the-command-that-you-build-with to webpack/vite, so unless someone wants to debug and fix this, the problem will go away with the switch to using webpack/vite directly 🎉 |
@NullVoxPopuli Thank you! I was captivated when I saw the https://github.com/lifeart/demo-ember-vite demo. Since joining an ember company from React - and losing access to vite/esbuild/etc I've been VERY sad about build and test times 😭 |
@jonathanstiansen there are a couple more vite-using projects, too:
there are more demo-land atm, but progress is ongoing! |
Intro
We have been noticing the same behavior across all our apps at work
and I was able to reproduce on a brand new app
The issue
After an amount of time that "seems" to be hovering around 20-30 minutes
ember test --server
stops sending the "start test" message over the websocket when files are changed. Even opening a new tab or a new window in a different browser does not fix the issue. All connected clients will not be notified when the code is changed.Furthermore (although I have less proof of this) even though
ember test --server
seems to recompile when code is changed it looks like the assets being server are not different and changes don't make their way into the compiled assetsThe only fix is to restart
ember test --server
reproduction
thanks for listening, happy to provide any more context or take suggestions on how to move this forward!
Output from
ember version --verbose && npm --version && yarn --version
:note that I was able to reproduce this on node 12 as well
The text was updated successfully, but these errors were encountered: