Update Ember to 1.9.0. #2714

rwjblue · 2014-12-09T23:03:21Z

No description provided.

rwjblue · 2014-12-09T23:18:22Z

Travis failed, I must've missed a few extra files. Will try to update tonight.

stefanpenner · 2014-12-10T00:09:20Z

i have afew minutes, looking into this now.

stefanpenner · 2014-12-10T00:19:07Z

bah this tests are so slow, i need to fix this.

stefanpenner · 2014-12-10T00:22:06Z

for reference the error is:

Missing template processor

Error: Missing template processor
    at module.exports.preprocessTemplates (/Users/stefan/src/ember-cli/lib/preprocessors.js:83:11)
    at Class.Addon.compileTemplates (/Users/stefan/src/ember-cli/lib/models/addon.js:227:12)
    at Class.Addon.compileAddon (/Users/stefan/src/ember-cli/lib/models/addon.js:241:28)
    at Class.Addon.treeForAddon (/Users/stefan/src/ember-cli/lib/models/addon.js:173:24)
    at Class._treeFor (/Users/stefan/src/ember-cli/lib/models/addon.js:118:31)
    at Class.treeFor (/Users/stefan/src/ember-cli/lib/models/addon.js:97:19)
    at EmberAddon.<anonymous> (/Users/stefan/src/ember-cli/lib/broccoli/ember-app.js:247:20)
    at Array.map (native)
    at EmberAddon.EmberApp.addonTreesFor (/Users/stefan/src/ember-cli/lib/broccoli/ember-app.js:245:30)
    at EmberAddon.EmberApp._processedVendorTree (/Users/stefan/src/ember-cli/lib/broccoli/ember-app.js:497:38)

    1) can render a component with a manually imported template
    2) "after each" hook

i may have been overzealous with clean test-output: issue opened #2716

stefanpenner · 2014-12-10T00:25:55Z

i believe the problem is the ember-cli-handlebars add-on may not yet have registered. This may also be why esnext + sass registered filters don't work correctly in add-ons yet.

stefanpenner · 2014-12-10T00:31:34Z

ah investigation cut short, will continue after my call.

rwjblue · 2014-12-10T00:39:47Z

Maybe there are other instances of package.json that I have missed? Will be back at a computer in an hour or two...=

stefanpenner · 2014-12-10T01:40:10Z

adding to debug logging it is being registered

DEBUG=ember-cli:registry* ./node_modules/.bin/mocha tests/acceptance/addon-smoke-test-slow.js

surprisingly it seems like we are re-adding many preprocessors more then i expected

stefanpenner · 2014-12-10T01:44:15Z

seems dubious: name: [object Object], ?

Wed, 10 Dec 2014 01:41:36 GMT ember-cli:registry add type: htmlbars-ast-plugin, name: [object Object], extension:undefined, options:undefined

Wed, 10 Dec 2014 01:41:36 GMT ember-cli:registry add type: htmlbars-ast-plugin, name: [object Object], extension:undefined, options:undefined

Wed, 10 Dec 2014 01:41:36 GMT ember-cli:registry remove type: template, name: broccoli-ember-hbs-template-compiler

Wed, 10 Dec 2014 01:41:36 GMT ember-cli:registry add type: template, name: [object Object], extension:undefined, options:undefined

gtg shopping with the wife, will be back in an hour or two.

sgasser · 2014-12-16T14:39:19Z

Any news?

rwjblue · 2014-12-18T16:30:14Z

blueprints/app/files/package.json

@@ -19,7 +19,7 @@
  "license": "MIT",
  "devDependencies": {
    "broccoli-asset-rev": "^2.0.0",
-    "broccoli-ember-hbs-template-compiler": "^1.6.1",
+    "ember-cli-htmlbars": "0.5.3",


Update to 0.5.4.

stefanpenner · 2014-12-20T15:14:21Z

@rwjblue i suspect this is actually uncovering a larger issue with addons currently. We should likely prioritize this for sometime in the next 2 weeks.

rwjblue · 2014-12-20T15:45:19Z

@stefanpenner - FYI - I have tracked the fundamental issue down for this (with the help of @teddyzeenny in ember-cli/ember-cli-htmlbars#34). I think I am going to need to rework the preprocessor initialization (the old preprocessor crap strikes again). Hoping to finish this today, so we can release 0.1.5 along with Ember 1.9.1 and 1.10.0-beta.2.

stefanpenner · 2014-12-20T16:54:59Z

@rwjblue 👍

stefanpenner · 2014-12-20T16:55:35Z

@rwjblue overlay somewhat with #2381 ?

rwjblue · 2014-12-20T17:06:24Z

@stefanpenner - Yes, absolutely.

pixelhandler · 2015-01-03T06:44:15Z

So I tried updating an addon to Ember 1.9.1 but get the error:

> ember serve
version: 0.1.5
Missing template processor
Error: Missing template processor
    at module.exports.preprocessTemplates (/Users/billheat/code/pixelhandler/ember-off-canvas-components/node_modules/ember-cli/lib/preprocessors.js:83:11)
    at Class.Addon.compileTemplates (/Users/billheat/code/pixelhandler/ember-off-canvas-components/node_modules/ember-cli/lib/models/addon.js:241:12)
    at Class.Addon.compileAddon (/Users/billheat/code/pixelhandler/ember-off-canvas-components/node_modules/ember-cli/lib/models/addon.js:255:28)
    at Class.Addon.treeForAddon (/Users/billheat/code/pixelhandler/ember-off-canvas-components/node_modules/ember-cli/lib/models/addon.js:187:24)
    at Class._treeFor (/Users/billheat/code/pixelhandler/ember-off-canvas-components/node_modules/ember-cli/lib/models/addon.js:132:31)
    at Class.treeFor (/Users/billheat/code/pixelhandler/ember-off-canvas-components/node_modules/ember-cli/lib/models/addon.js:111:19)
    at EmberAddon.<anonymous> (/Users/billheat/code/pixelhandler/ember-off-canvas-components/node_modules/ember-cli/lib/broccoli/ember-app.js:264:20)
    at Array.map (native)
    at EmberAddon.EmberApp.addonTreesFor (/Users/billheat/code/pixelhandler/ember-off-canvas-components/node_modules/ember-cli/lib/broccoli/ember-app.js:262:30)
    at EmberAddon.EmberApp._processedVendorTree (/Users/billheat/code/pixelhandler/ember-off-canvas-components/node_modules/ember-cli/lib/broccoli/ember-app.js:514:38)

I tried an update to the ember-off-canvas-components repo to ember-cli v0.1.5 and updating to ember 1.9.1 as well. I uninstalled the old template processor and installed the new one as suggested in the blog post for Ember 1.9 release here http://emberjs.com/blog/2014/12/08/ember-1-9-0-released.html

Uninstalled "broccoli-ember-hbs-template-compiler": "^1.6.1",
Installed "ember-cli-htmlbars": "^0.6.0",

But ember build still results in an error “Error: Missing template processor”. The sad part is that the only template used in this repo is “{{yield}}”. I pushed those changes to master at git@github.com:pixelhandler/ember-off-canvas-components.git I may not be able to update the ember cli addon to use ember 1.9.1 with this open issue.

stefanpenner · 2015-01-03T06:48:48Z

ya we should dig into this this weekend. It is related to correcting our add-on story. I suppose it depends how deep we want to go this time around.

switch from broccoli-ember-hbs-template-compiler to ember-cli-htmlbars quick hack so we can proceed with moving common code to components discussion about real fix: ember-cli#2714

kielni · 2015-01-09T19:15:49Z

@pixelhandler it's not a long-term or general fix, but if you need this to work now (like I do), you could use my fork where I changed the template preprocessor to ember-cli-htmlbars:

https://github.com/kielni/ember-cli/tree/ember-cli-htmlbars-preprocessor

jayphelps · 2015-01-10T00:54:54Z

Did something change w/ ember-cli-htmlbars v0.6.0? I just upgraded an app to ember v1.10.0-beta.3 w/ ember-cli v0.1.5 and it works flawlessly. (after I fixed all the malformed template HTML that htmlbars found 😏)

rwjblue · 2015-01-10T02:05:14Z

@jayphelps - It does work, but not for addons with templates (which is kind of a big deal). The issue was explained best by @teddyzeeny in ember-cli/ember-cli-htmlbars#34.

Gaurav0 · 2015-01-22T23:44:06Z

Any update on this issue?

benlesh · 2015-02-02T18:43:01Z

Is there any way I can contribute on this? Are there any public discussions around what the problem is and what the fix should be so I can get a handle on what needs to be done?

jayphelps · 2015-02-02T18:45:03Z

@Blesh See #3166

stefanpenner · 2015-02-02T19:19:44Z

Is there any way I can contribute on this? Are there any public discussions around what the problem is and what the fix should be so I can get a handle on what needs to be done?

its just the way we config add ons. Also, please remember it is only the bundled version of ember-cli that can't be setup correctly. In your own apps everything will work fine, hence the somewhat low priority fix.

benlesh · 2015-02-02T20:00:07Z

Also, please remember it is only the bundled version of ember-cli that can't be setup correctly.

I'm confused about what a "bundled" version of ember-cli is, versus a "non-bundled" version.

corsen2000 · 2015-02-02T20:22:30Z

I'm also having issues and am a little confused. Is the gist of this that users developing addons can not upgrade at this time?

I am developing an addon and tried following the steps here:
http://emberjs.com/blog/2014/10/16/handlebars-update.html#toc_ember-cli-steps

lukemelia · 2015-02-03T02:03:05Z

Currently, addons cannot use preprocessors that are not among the default
set registered by default by ember-cli. Unfortunately, the won't-work set
includes ember-cli-htmlbars and ember-cli-6to5. As linked above, I hope to
have a fix ready to merge in the next few days.

On Monday, February 2, 2015, Bryan C notifications@github.com wrote:

I'm also having issues and am a little confused. Is the gist of this that
users developing addons can not upgrade at this time?

I am developing an addon and tried following the steps here:

http://emberjs.com/blog/2014/10/16/handlebars-update.html#toc_ember-cli-steps

—
Reply to this email directly or view it on GitHub
#2714 (comment).

corsen2000 · 2015-02-03T04:09:07Z

@lukemelia thanks for the clarification.

stefanpenner · 2015-02-23T23:17:37Z

we are on 1.10.x now

bj-mcduck · 2015-05-22T15:43:40Z

A bit confused here, I have an addon I'm making that uses a template. Does this mean that currently no matter where I put it in the addon, it won't show up?

Been trying to place it all over trying to figure out what the right convention is for it to live.

rwjblue force-pushed the update-ember branch from 7579c16 to 43f09af Compare December 15, 2014 02:14

rwjblue reviewed Dec 18, 2014
View reviewed changes

Update Ember to 1.9.0.

8dcec4d

rwjblue force-pushed the update-ember branch from 43f09af to 8dcec4d Compare December 18, 2014 19:03

This was referenced Dec 20, 2014

Compiler added to app registry but not to addons ember-cli/ember-cli-htmlbars#34

Closed

Unit test for model requires inclusion of any other "referenced" model into needs. emberjs/ember-test-helpers#6

Closed

stefanpenner mentioned this pull request Dec 20, 2014

With HTMLBars template processing differs for addons vs. apps #2742

Closed

stefanpenner added the bug label Dec 20, 2014

stefanpenner assigned rwjblue Dec 20, 2014

rwjblue removed their assignment Dec 21, 2014

abuiles mentioned this pull request Dec 27, 2014

Start preparations for 0.1.5. #2822

Merged

stefanpenner mentioned this pull request Dec 30, 2014

When will ember-cli upgrade beyond ember 1.8.1 ? #2853

Closed

stefanpenner mentioned this pull request Jan 28, 2015

Ember CLI to work with Ember 1.9.1 (and Handlebars 2.0) #3137

Closed

lukemelia mentioned this pull request Jan 31, 2015

Addon discovery and isolation #3166

Merged

18 tasks

stefanpenner closed this Feb 23, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Ember to 1.9.0. #2714

Update Ember to 1.9.0. #2714

rwjblue commented Dec 9, 2014

rwjblue commented Dec 9, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

rwjblue commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

sgasser commented Dec 16, 2014

rwjblue Dec 18, 2014

stefanpenner commented Dec 20, 2014

rwjblue commented Dec 20, 2014

stefanpenner commented Dec 20, 2014

stefanpenner commented Dec 20, 2014

rwjblue commented Dec 20, 2014

pixelhandler commented Jan 3, 2015

stefanpenner commented Jan 3, 2015

kielni commented Jan 9, 2015

jayphelps commented Jan 10, 2015

rwjblue commented Jan 10, 2015

Gaurav0 commented Jan 22, 2015

benlesh commented Feb 2, 2015

jayphelps commented Feb 2, 2015

stefanpenner commented Feb 2, 2015

benlesh commented Feb 2, 2015

corsen2000 commented Feb 2, 2015

lukemelia commented Feb 3, 2015

corsen2000 commented Feb 3, 2015

stefanpenner commented Feb 23, 2015

bj-mcduck commented May 22, 2015

Update Ember to 1.9.0. #2714

Update Ember to 1.9.0. #2714

Conversation

rwjblue commented Dec 9, 2014

rwjblue commented Dec 9, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

rwjblue commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

stefanpenner commented Dec 10, 2014

sgasser commented Dec 16, 2014

rwjblue Dec 18, 2014

Choose a reason for hiding this comment

stefanpenner commented Dec 20, 2014

rwjblue commented Dec 20, 2014

stefanpenner commented Dec 20, 2014

stefanpenner commented Dec 20, 2014

rwjblue commented Dec 20, 2014

pixelhandler commented Jan 3, 2015

stefanpenner commented Jan 3, 2015

kielni commented Jan 9, 2015

jayphelps commented Jan 10, 2015

rwjblue commented Jan 10, 2015

Gaurav0 commented Jan 22, 2015

benlesh commented Feb 2, 2015

jayphelps commented Feb 2, 2015

stefanpenner commented Feb 2, 2015

benlesh commented Feb 2, 2015

corsen2000 commented Feb 2, 2015

lukemelia commented Feb 3, 2015

corsen2000 commented Feb 3, 2015

stefanpenner commented Feb 23, 2015

bj-mcduck commented May 22, 2015