BUGFIX Fixes #3472 Check for 'usePods' instead of 'pod'.

[jankrueger]

Fixes #3472 by checking for 'options.usePods' instead of 'options.pod'

[rwjblue]

@trabus - 👍 / 👎 ?

[trabus]

usePods is the wrong value to be checking for. The options.pod value is passed on from the generate command, and should be present in locals, if it's not that's a bug that needs to be investigated.

[trabus]

@jankrueger So the fix is actually just as simple, but belongs in the blueprint model here. When the value for usePods is present, we're inverting the value of options.pod, but not setting the value back on options.pod. We need to fix the options.pod value to be the correct value when usePods is true.

We have two options.
First would be to mutate the options.pod value from the blueprint model (quickest option)

// lib/models/blueprint.js install and destroy methods
var pod = (options.settings && options.settings.usePods) ? !options.pod : options.pod;
this.pod = options.pod = pod;

The second would be to check for usePods earlier in the generate and destroy commands, and set the value there. (cleaner option, handled upstream, preferred)

// lib/commands/generate.js and lib/commands/destroy.js
 if(this.settings && this.settings.usePods) {
   commandOptions.pod = !commandOptions.pod;
 }
 var taskOptions = merge(taskArgs, commandOptions || {});

// lib/models/blueprint.js install and destroy methods
this.pod     = options.pod;

We should probably add a test for this as well, you should be able to add one in tests/acceptance/pods-generate-test.js

[jankrueger]

@trabus Thanks for clarification!
There seems to be a test in place that is failing. I will fix that hopefully tonight with this pr.

[trabus]

@jankrueger The existing tests should be fine after this fix, just be sure to revert the change in the component blueprint. I was suggesting we add an additional generate test with usePods set.

Regarding additional tests, you should be able to copy this one, and change the values being passed. You'll just need to adjust what the expected output should be so it matches what a component generates.

[jankrueger]

@trabus I implemented your preferred version and changed the commandOptions in the generate/destroy command. The failing test is now passing and i added two more tests as suggested.

[trabus]

@jankrueger Looking good! 👍

Can @rwjblue or @stefanpenner review, please?

[rwjblue]

LGTM

[rwjblue]

@jankrueger / @trabus - Thanks for working together on this!