Component blueprint only import layout when generated inside addon #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will refactor tests after #3481 is merged in, as it will have an effect on them. |
|
#3481 is merged now |
|
@rwjblue Thanks! |
trabus
force-pushed
the
component-layout-import
branch
from
dc55a2b
to
8a5acc2
Compare
trabus
changed the title
trabus
force-pushed
the
component-layout-import
branch
from
8a5acc2
to
d5d8c80
Compare
|
@rwjblue ready for review. |
rwjblue
added a commit
that referenced
this pull request
Mar 11, 2015
Component blueprint only import layout when generated inside addon
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the layout import statement when generating components in a regular project. Still has import statement when generating inside an addon project.
This issue was found as part of #3472
Need to add/update tests still.