Check if style file with project name exists #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a style sheet file named the same as the project exists will cause an exception when building. The error is not very obvious. This check prevents the build and displays an error.
|
Seems good to provide a nice warning here. It will only be checked on initial build (which seems OK to me). @stefanpenner - r? |
|
@rwjblue should this be a silent error? |
|
Yes, definitely (good catch!). @btecu - Can you update to use |
|
Done. |
|
re-kicking app-veyor |
rwjblue
added a commit
that referenced
this pull request
Mar 26, 2015
Check if style file with project name exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a style sheet file named the same as the project exists will cause an exception when building. The error is not very obvious. This check prevents the build and displays an error.