Remove "style file" silent error #7600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Feb 4, 2018
lib/broccoli/ember-app.js
Outdated
| if (existsSync(`${this._stylesPath}/${this.name}.css`)) { | ||
| throw new SilentError(`Style file cannot have the name of the application - ${this.name}`); | ||
| } | ||
| //if (existsSync(`${this._stylesPath}/${this.name}.css`)) { |
There was a problem hiding this comment.
If we are going to remove it, let’s remove it. Commenting seems bad....
There was a problem hiding this comment.
ofc, Good Sir. I opened this PR just to start a conversation.
|
@rwjblue I did test it locally and it works just fine, both |
This check was originally added as a part of [this PR](#3642). Motivation behind the change was that build crashed w/ not-so-obvious error if stylesheet file had the same name as the project.
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was originally added as a part of this PR. Motivation behind the change was that build crashed w/ not-so-obvious error if stylesheet file had the same name as the project. I have doubts this check needs to exist anymore.