[ENHANCEMENT] install:addon command will show a deprecation message before running the install command.

[DanielOchoa]

Given that a lot of ember-cli addon projects tell you to install them through the ember install:addon command, I re-added the command so it can throw a friendly error that points to the now correct command ember install. This is related to #3598 (comment).

[stefanpenner]

👍

[rwjblue]

Typically, a deprecation will still "work" with a warning. In this case, it seems that we just throw a SilentError and the user needs to run the alternate command.

I would prefer that this extended the current install command, and added the deprecation before calling _super in init. That way it doesn't duplicate code to make it work, and isn't annoying to consumers who have to retype their command.

What do y'all think?

[DanielOchoa]

You are right, it is not a deprecation but simply a silent error. I like where you are going with this, I'll make the necessary change to extend from the install command.

[DanielOchoa]

Interesting. For some reason init gets called twice. It's not being instantiated two times, it's only the init function being called twice.

Do you have any input on this @rwjblue ?

[raycohen]

any movement on this? we're having to put two different sets of install instructions on our repos

[stefanpenner]

any movement on this?

kicking travis

we're having to put two different sets of install instructions on our repos

Why? Or are you catering to old versions of ember-cli?

[stefanpenner]

this._super.init.call(this);

[stefanpenner]

Interesting. For some reason init gets called twice. It's not being instantiated two times, it's only the init function being called twice.

Do you have any input on this @rwjblue ?

this is most likely the result of us still being on a broken version of core-object. #3056 sorta stalled, but we should try to re-ignite that effort.

cc @jgwhite

[jgwhite]

@stefanpenner yes, yes we should :guilty_face:

[DanielOchoa]

I figured as much 😸

[raycohen]

@stefanpenner yes, catering to both...

[DanielOchoa]

I'll update the pull request to reflect master ..