Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow addons to have pod based templates #4158

Merged
merged 2 commits into from May 26, 2015
Merged

Allow addons to have pod based templates #4158

merged 2 commits into from May 26, 2015

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented May 24, 2015

Updated version of #3596, fixes #3586.

@gmurphey
Copy link
Contributor

Thanks for getting the ball rolling on this again, @pzuraq!

@pzuraq
Copy link
Contributor Author

pzuraq commented May 26, 2015

No prob! I realize the upcoming packager refactor may make this approach obsolete, but we're pushing pod structure in our addons so the sooner it gets in the better.

@stefanpenner
Copy link
Contributor

@pzuraq yes, i believe an intermediate step is very reasonable.

@chadhietala can you review this, I want to be sure we don't deviate from the packager works.

@chadhietala
Copy link
Member

@stefanpenner We may not need this in the future, but this doesn't deviate.

stefanpenner added a commit that referenced this pull request May 26, 2015
Allow addons to have pod based templates
@stefanpenner stefanpenner merged commit dc0f5d3 into ember-cli:master May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod templates inside addons don't get compiled
5 participants