Skip to content
This repository has been archived by the owner on Jan 20, 2019. It is now read-only.

Packager RFC #14

Closed
wants to merge 6 commits into from
Closed

Packager RFC #14

wants to merge 6 commits into from

Conversation

chadhietala
Copy link
Member

- Merges an addon's app directory with the consuming app
- Transpiles ES2015-modules code to AMD

As part of the ES2015-modules transpilation we drop a `dep-graph.json` at the root of each tree. This is used by the Pre-Packager to resolve the graph. The result of this phase is an array of Broccoli trees containing all of the built assets in the app and addons.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop -> place

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resovle -> satisfy

@dschmidt
Copy link
Contributor

dschmidt commented Jul 7, 2015

  1. Is this only about imported dependencies or are you already going to handle dependencies of templates in this step (like helpers/components/etc)? Tbh I don't know how HTMLbars templates work: Do they already import everything that is needed so it's not even a special case for you to handle?
App and addon resolution uses the dep-graph.json to start the traversal. By default, the Pre-Packager uses the App as the entry into the graph, but developers can supply N entries. More on this later, but for now you should think of an entry as a large functional area of an application (the admin section, the main app, etc). 

and

  entries: ['my-app'], // Optional if you're only building your app

Can you elaborate a bit more on this? Are you planning on enabling mutliple apps per project? I want to create embeddable widgets off a large application. It of course should not load all the templates and dependencies of the main application.
I'm currently checking out options for this, engines might be one solution when they land - but that seems a bit farther ahead than this.
Moving everything that is shared between main app and widgets into an addon is very cumbersome and seems hackish if I want to keep a certain level of convernience while developing both apps at once.
So if this would enable me to build an app.js and a widgets.js with corresponding .html files in the same project but based on different entry points, that would be more than awesome.

@rwjblue
Copy link
Member

rwjblue commented Jan 19, 2019

We are working on closing the ember-cli/rfcs repo in favor of using a single central RFC's repo for everything. This was laid out in https://emberjs.github.io/rfcs/0300-rfc-process-update.html.

Sorry for the troubles, but would you mind reviewing to see if this is still something we need, and if so migrating this over to emberjs/rfcs?

Thank you!

@rwjblue rwjblue closed this Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants