Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating deprecations that use the deprecate utility #5179

Merged
merged 4 commits into from
Dec 13, 2015
Merged

Updating deprecations that use the deprecate utility #5179

merged 4 commits into from
Dec 13, 2015

Conversation

gmurphey
Copy link
Contributor

@gmurphey gmurphey commented Dec 3, 2015

Updating deprecations that use the deprecate utility to use the deprecateUI method instead. Fixes #5176.

This will make deprecation messages obey --silent flags in commands.

@stefanpenner
Copy link
Contributor

not your fault, but deprecateUI API is horrible. I would love to accept a PR for an alternative, maybe ui.writeDeprecatedLine?

But your PR itself (giving the existing API) seems good. Do you have a chance to add a quick unit test to ensure we dont regress?

@gmurphey
Copy link
Contributor Author

gmurphey commented Dec 3, 2015

I was just thinking that it would be nice to have some helper methods within ui to handle chalk colors automatically, so I'll put together a writeDeprecatedLine helper now.

@gmurphey
Copy link
Contributor Author

gmurphey commented Dec 3, 2015

This should be ready for review now. I changed the way the test argument for deprecations worked to more closely match the Ember.deprecate and Ember.warn implementations.

@gmurphey gmurphey force-pushed the deprecations-silent-flag branch 2 times, most recently from e7751f8 to e326d2d Compare December 3, 2015 04:59
@stefanpenner
Copy link
Contributor

LGTM

@stefanpenner
Copy link
Contributor

@homu r+

@homu
Copy link
Contributor

homu commented Dec 3, 2015

📌 Commit d6a8c6c has been approved by stefanpenner

@homu
Copy link
Contributor

homu commented Dec 3, 2015

⌛ Testing commit d6a8c6c with merge 2cd5db6...

homu added a commit that referenced this pull request Dec 3, 2015
@homu
Auto merge of #5179 - gmurphey:deprecations-silent-flag, r=stefanpenner
2cd5db6 
Updating deprecations that use the deprecate utility

Updating deprecations that use the deprecate utility to use the `deprecateUI` method instead. Fixes #5176.

This will make deprecation messages obey `--silent` flags in commands.
@homu
Copy link
Contributor

homu commented Dec 3, 2015

💔 Test failed - status

@stefanpenner
Copy link
Contributor

master is green, i suspect these failures might be legit?

@gmurphey
Copy link
Contributor Author

gmurphey commented Dec 3, 2015

They're legit. Fixed those and running the whole test suite locally now.

@stefanpenner
Copy link
Contributor

They're legit. Fixed those and running the whole test suite locally now.

:)

@gmurphey
Copy link
Contributor Author

gmurphey commented Dec 4, 2015

It seems like there may be some AppVeyor errors in master? https://github.com/ember-cli/ember-cli/pull/5165/files#diff-bcc1cfee5da25b748d30502649279e4bR256

@gmurphey
Copy link
Contributor Author

gmurphey commented Dec 4, 2015

Fixing AppVeyor on #5186

@stefanpenner
Copy link
Contributor

@gmurphey you are both a scholar and a gentleman

@gmurphey
Copy link
Contributor Author

gmurphey commented Dec 4, 2015

@stefanpenner :)

Did a quick rebase to hopefully get these tests green.

@gmurphey
Copy link
Contributor Author

gmurphey commented Dec 4, 2015

Seems like AppVeyor had some timeout issues.

@stefanpenner
Copy link
Contributor

kicking

@gmurphey
Copy link
Contributor Author

gmurphey commented Dec 5, 2015

I must've wronged AppVeyor in a past life. Still getting some timeout issues, but 4.2 passes.

@rwjblue
Copy link
Member

rwjblue commented Dec 5, 2015 via email

@rwjblue
Copy link
Member

rwjblue commented Dec 5, 2015

@homu retry

Garrett Murphey added 4 commits December 9, 2015 14:34
Creating helper methods for debug, info, warning, and deprecation mes…
139975c 
…sages. Switching deprecations that were using the deprecate utility over to these new helpers.

This will make deprecation messages obey --silent flags in commands. Fixes ember-cli#5176.
Deprecating deprecateUI utility in favor of ui.writeDeprecateLine.
68d8ac3
Tackling low-hanging ui output that can be handled by ui helpers.
36e36d7
Fixing lookup-command warning tests.
d543965
@rwjblue
Copy link
Member

rwjblue commented Dec 13, 2015

@homu r+

@homu
Copy link
Contributor

homu commented Dec 13, 2015

📌 Commit d543965 has been approved by rwjblue

homu added a commit that referenced this pull request Dec 13, 2015
@homu
Auto merge of #5179 - gmurphey:deprecations-silent-flag, r=rwjblue
7ff1fbd 
Updating deprecations that use the deprecate utility

Updating deprecations that use the deprecate utility to use the `deprecateUI` method instead. Fixes #5176.

This will make deprecation messages obey `--silent` flags in commands.
@homu
Copy link
Contributor

homu commented Dec 13, 2015

⌛ Testing commit d543965 with merge 7ff1fbd...

@homu
Copy link
Contributor

homu commented Dec 13, 2015

☀️ Test successful - status

@homu homu merged commit d543965 into ember-cli:master Dec 13, 2015
This was referenced Dec 13, 2015
Merged
Merged
@gmurphey gmurphey deleted the deprecations-silent-flag branch December 15, 2015 18:29
@gmurphey gmurphey mentioned this pull request Dec 22, 2015
Merged
@rwjblue rwjblue mentioned this pull request Aug 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gmurphey @stefanpenner @homu @rwjblue