Fixing path issue in test for AppVeyor. #5186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, good catch. Lgtm |
|
Will let AppVeyor run before approving with @homu. Good catch, thanks for tracking that down! |
gmurphey
force-pushed
the
fix-path-for-appveyor
branch
from
510feba
to
fb1f700
Compare
gmurphey
force-pushed
the
fix-path-for-appveyor
branch
from
fb1f700
to
eeaaf9a
Compare
|
Hopefully soon homu will work with appveyor |
|
Not sure if these AppVeyor failures are legit? |
|
Looks like node 4.2 passed on AppVeyor (the others had timeouts), so I'm good to go on this. Thanks again for tracking down the source of the failure. @homu r+ |
|
📌 Commit eeaaf9a has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Dec 4, 2015
Fixing path issue in test for AppVeyor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.