Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use eol=lf for windows #5345

Merged
merged 1 commit into from
Jan 14, 2016
Merged

Conversation

kellyselden
Copy link
Member

from the file:

# force unix line endings on all files, needed for Windows npm publishing
# https://github.com/ember-cli/ember-cli/issues/5342
# this may be a temporary solution, as it may affect the dev flow for Windows
# contributors that aren't npm publishers
# another solution may be https://www.npmjs.com/package/npm-text-auto

cc @stefanpenner @rwjblue

@stefanpenner
Copy link
Contributor

+# this may be a temporary solution, as it may affect the dev flow for Windows

i've always been confused by this, is it reasonable to expect this to not be an issue for windows contributors ? Or is it reasonable to expect it.

@kellyselden
Copy link
Member Author

In my experience, it's nothing more than a minor inconvenience. Any programming editor or IDE will render the \n. The only time you will notice is if you open it up in notepad.exe, all lines are munged onto one line. Then you know just to open it in another editor.

Would love to hear from some other Windows devs.

@stefanpenner
Copy link
Contributor

@kellyselden I'm fine with requiring unix new lines, even for windows developers. As long as we quickly document it in the readme, then I'm on-board.

@jonnii
Copy link
Contributor

jonnii commented Jan 13, 2016

most windows devs are used to this horrible garbage.

@rwjblue
Copy link
Member

rwjblue commented Jan 14, 2016

Seems reasonable to try. We can always revisit if it causes Windows devs of ember-cli pain.

stefanpenner added a commit that referenced this pull request Jan 14, 2016
@stefanpenner stefanpenner merged commit 0c55b59 into ember-cli:master Jan 14, 2016
@kellyselden kellyselden deleted the windows-lf branch January 14, 2016 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants