Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to lodash 4 #5367

Merged
merged 1 commit into from Jan 20, 2016
Merged

Update to lodash 4 #5367

merged 1 commit into from Jan 20, 2016

Conversation

jcope2013
Copy link
Contributor

Relevant change include

  • Removed category names from module paths
  • contains alias removed in favor of includes
  • pluck removed in favor of map
  • where removed in favor of filter
  • omit no longer takes function argument, use omitBy/isNull
  • uniq no longer takes function argument, use uniqBy

https://github.com/lodash/lodash/wiki/Changelog

@stefanpenner
Copy link
Contributor

Awesome thanks!

@homu r+

@homu
Copy link
Contributor

homu commented Jan 16, 2016

📌 Commit d6b7db4 has been approved by stefanpenner

@homu
Copy link
Contributor

homu commented Jan 16, 2016

⌛ Testing commit d6b7db4 with merge 3ab5d1f...

homu added a commit that referenced this pull request Jan 16, 2016
Update to lodash 4

Relevant change include

- Removed category names from module paths
- contains alias removed in favor of includes
- pluck removed in favor of map
- where removed in favor of filter

https://github.com/lodash/lodash/wiki/Changelog
@homu
Copy link
Contributor

homu commented Jan 16, 2016

💔 Test failed - status

@jcope2013
Copy link
Contributor Author

tests should pass now

@kellyselden
Copy link
Member

@homu retry

1 similar comment
@stefanpenner
Copy link
Contributor

@homu retry

@stefanpenner
Copy link
Contributor

@home r+

@kellyselden
Copy link
Member

@stefanpenner homu doesn't like us anymore apparently

@stefanpenner
Copy link
Contributor

@homu +r (i did typo above, lets try again)

homu added a commit that referenced this pull request Jan 17, 2016
Update to lodash 4

Relevant change include

- Removed category names from module paths
- contains alias removed in favor of includes
- pluck removed in favor of map
- where removed in favor of filter
- omit no longer takes function argument, use omitBy/isNull
- uniq no longer takes function argument, use uniqBy

https://github.com/lodash/lodash/wiki/Changelog
@homu
Copy link
Contributor

homu commented Jan 17, 2016

⌛ Trying commit ad42f25 with merge d775f9f...

@homu
Copy link
Contributor

homu commented Jan 17, 2016

☀️ Test successful - status

@trabus
Copy link
Contributor

trabus commented Jan 18, 2016

@jcope2013 I think you may have missed this line:
https://github.com/ember-cli/ember-cli/blob/master/lib/models/file-info.js#L18

If you could move that require up so it's not used inline, that would be awesome.

@trabus
Copy link
Contributor

trabus commented Jan 19, 2016

Looks like AppVeyor is still having issues with the blueprint tests, which are most likely related to the file-info use of lodash/template. Uncertain if there are any changes that would affect the template rendering on Windows, but that seems like a good place to start looking.

@jcope2013
Copy link
Contributor Author

@trabus not sure they are related to this PR as they are failing in other PR's also #5374 and a whole bunch of other ones

@trabus
Copy link
Contributor

trabus commented Jan 19, 2016

@jcope2013 @kellyselden Looks like they started with this PR:
#5345

It seems the change of the eol character changed the result to something other than what the tests were expecting.

@stefanpenner
Copy link
Contributor

they are failing, (to do timeouts, yes we must address that) but as @trabus pointed out there are also template specific issues in this test run.

stefanpenner added a commit that referenced this pull request Jan 20, 2016
@stefanpenner stefanpenner merged commit 282641b into ember-cli:master Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants