New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to lodash 4 #5367
Update to lodash 4 #5367
Conversation
Awesome thanks! @homu r+ |
📌 Commit d6b7db4 has been approved by |
Update to lodash 4 Relevant change include - Removed category names from module paths - contains alias removed in favor of includes - pluck removed in favor of map - where removed in favor of filter https://github.com/lodash/lodash/wiki/Changelog
💔 Test failed - status |
tests should pass now |
@homu retry |
1 similar comment
@homu retry |
@home r+ |
@stefanpenner homu doesn't like us anymore apparently |
@homu +r (i did typo above, lets try again) |
Update to lodash 4 Relevant change include - Removed category names from module paths - contains alias removed in favor of includes - pluck removed in favor of map - where removed in favor of filter - omit no longer takes function argument, use omitBy/isNull - uniq no longer takes function argument, use uniqBy https://github.com/lodash/lodash/wiki/Changelog
☀️ Test successful - status |
@jcope2013 I think you may have missed this line: If you could move that require up so it's not used inline, that would be awesome. |
Looks like AppVeyor is still having issues with the blueprint tests, which are most likely related to the |
@jcope2013 @kellyselden Looks like they started with this PR: It seems the change of the eol character changed the result to something other than what the tests were expecting. |
they are failing, (to do timeouts, yes we must address that) but as @trabus pointed out there are also template specific issues in this test run. |
Relevant change include
https://github.com/lodash/lodash/wiki/Changelog