add ability to clean up old files in generators #6472
Conversation
|
I like the idea, but ya as you mentioned we will likely need to bikeshed the API somewhat. Likely a small RFC to get that ball rolling would be appropriate. |
|
☔ The latest upstream changes (presumably #6473) made this pull request unmergeable. Please resolve the merge conflicts. |
kellyselden
force-pushed
the
blueprint-file-remove
branch
from
813a90e
to
fea2069
Compare
|
☔ The latest upstream changes (presumably #6636) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@kellyselden - ember-cli/rfcs#92 has been merged, can you rebase this and update to get it passing CI? |
|
Anyone want a better name than |
kellyselden
force-pushed
the
blueprint-file-remove
branch
from
fea2069
to
dc69595
Compare
Just an option - |
|
@ro0gr That could be confused with |
|
@kellyselden I've checked the meaning of the word
Usually I tend to cleanup things of this kind 😃 Anyway I don't have strong opinion for the name here, just want to share an option. |
|
I'd prefer:
I'm generally not a fan of using "old" or "new" in names.... |
|
|
|
@kellyselden - Sounds good, I'd say go ahead and update... |
Revert changes removing `bower.json` from default blueprints. This reverts commit be142aa, reversing changes made to b90f860. This is being reverted due to user experience issues when the `bower.json` file is no longer part of the blueprint. As things exist prior to a revert, any user upgrading from a version of ember-cli prior to 2.11 would never be instructed to update their `bower.json` to remove entries for `ember`, `ember-cli-shims`, etc. To bring the changes being reverted back, we need to land the ability for a blueprint to indicate that a file should be deleted as part of the `ember init` process. This was RFC'ed in ember-cli/rfcs#92 and the implementation is pending in #6472 and should hopefully land in 2.13 (current ember-cli#master branch). This was discussed at the ember-cli meeting on 2017-01-26.
kellyselden
force-pushed
the
blueprint-file-remove
branch
from
dc69595
to
7490f05
Compare
kellyselden
changed the title
|
Rebased and changed to |
kellyselden
force-pushed
the
blueprint-file-remove
branch
from
7490f05
to
4bbc753
Compare
kellyselden
force-pushed
the
blueprint-file-remove
branch
from
4bbc753
to
2cfb76e
Compare
|
@homu r+ |
|
📌 Commit 2cfb76e has been approved by |
|
⚡ Test exempted - status |
add ability to clean up old files in generators A response to #6469 (comment) This will probably need an RFC because it introduces a new blueprint member `oldFilesToRemove`. A blueprint can override the array and give a list of old file names that the generator (ember init or your own custom blueprint) will clean up for you.
A response to #6469 (comment)
This will probably need an RFC because it introduces a new blueprint member
oldFilesToRemove. A blueprint can override the array and give a list of old file names that the generator (ember init or your own custom blueprint) will clean up for you.