[BUGFIX] Fix remaining ember-source issues.

[nathanhammond]

The removal from bower meant that we were erroneously removing it from ember-source. No longer.

[rwjblue]

This change seems somewhat odd. The idea here was that a different addon could provide the shims. That would work even with using Ember from bower.

[nathanhammond]

The ember-source build provides shims every time.

@martndemus this was introduced in #6254. What is the story behind this check?

[nathanhammond]

In other words, what's the story of this: #6254 (comment)

It's distinct from the ember-resolver issue but in that PR.

[ghost]

What @rwjblue said, to be able to provide my own shims addon.

[nathanhammond]

I'm actually rather opposed to this check existing as it makes the failure for not including shims move to runtime where we can't control it as easily and manifests as:

cannot find module 'ember'

Regardless, knowing the story makes it possible for me to address. Thank you!

[nathanhammond]

Okay, so the only thing which requires this change is ember-new-modules-shim. The users of that addon should be assumed to be highly familiar Ember devs.

Given that, if users of ember-new-modules-shim wish to not include ember-cli-shims they will need to follow the full set of instructions at https://github.com/DockYard/ember-new-modules-shim#optional-disabling-ember-cli-shims ... not just remove the bower dependency and rely on this change.

That is the only way we can make sure that shims are not included across both ember-source-provided and bower-provided shims while knowing user intent.

[rwjblue]

👍 , seems good

[nathanhammond]

Skipping @homu because CI is broken.

[ghost]