Work around broken bower installation for old npm versions #6885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can skip installing bower if `bower.json` exists but there are actually no dependencies inside
rwjblue
approved these changes
Mar 21, 2017
|
@homu r+ |
|
📌 Commit a97b0cb has been approved by |
homu
added a commit
that referenced
this pull request
Mar 21, 2017
Work around broken bower installation for old npm versions This PR: - checks the error message returned from `npm install bower` and displays a helpful error message if the known bug was hit - checks if the `bower.json` actually has any dependencies before trying to `npm install bower` so that the first case should become a rare edge case when used with a custom app blueprint that still includes bower dependencies Resolves #6863
|
⚡ Test exempted - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
checks the error message returned from
npm install bowerand displays a helpful error message if the known bug was hitchecks if the
bower.jsonactually has any dependencies before trying tonpm install bowerso that the first case should become a rare edge case when used with a custom app blueprint that still includes bower dependenciesResolves #6863