Make async/await work nicely by default. #7548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyselden
approved these changes
Jan 11, 2018
kratiahuja
approved these changes
Jan 11, 2018
This change does a few things: * Add `ember-maybe-import-regenerator` to the default blueprint. * Drop IE9 from `config/targets.js`, and replace with IE11 (to match Ember 3.0.0's minimum browser requirements). * Modify `config/targets.js` to make development builds target modern browsers. This essentially brings over the configuration discussed in [this blog post](http://rwjblue.com/2017/10/30/async-await-configuration-adventure/): * [Section 30](http://rwjblue.com/2017/10/30/async-await-configuration-adventure/#install-maybe-install-regenerator) * [Section 10](http://rwjblue.com/2017/10/30/async-await-configuration-adventure/#limit-targets-locally)
rwjblue
force-pushed
the
nicer-async-await
branch
from
d7712fd
to
7798114
Compare
|
FWIW I'm a little worried about dev being built differently from prod now... 🤔 |
|
CI also checks the transpiled version too. |
|
yeah, I've seen that... still got a somewhat bad feeling about this |
|
Hmm. We should discuss in higher bandwidth. That specific part was not the high order bit here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does a few things:
ember-maybe-import-regeneratorto the default blueprint.config/targets.js, and replace with IE11 (to matchEmber 3.0.0's minimum browser requirements).
config/targets.jsto make development builds target modernbrowsers.
This essentially brings over the configuration discussed in this blog post: