Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude addon-test-support from eslint node files #7659

Merged
merged 2 commits into from Mar 5, 2018
Merged

Exclude addon-test-support from eslint node files #7659

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbf3cea
Exclude addon-test-support from eslint node files
m-basov Mar 2, 2018
c89b7f2
Update addon .eslintrc.js fixtures
m-basov Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion blueprints/app/files/.eslintrc.js
View file
Open in desktop
Expand Up @@ -30,7 +30,8 @@ module.exports = {
excludedFiles: [
'app/**',
'addon/**',
'tests/dummy/app/**'
'tests/dummy/app/**',
'addon-test-support/**'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added in the same way as the other addon specific overrides (since it doesn't apply to apps at all)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwjblue sorry, not sure if I understood you. This is now inside of if statement blueprint !== 'app' which means it will be not included to apps at all. Please correct me if I am wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOH! You are totally correct, sorry for not seeing that.

],<% } %>
parserOptions: {
sourceType: 'script',
Expand Down