new mu-app blueprint does not add tests/{unit,integration} folders
#8194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
ppcano
force-pushed
the
mu-new-blueprint-files
branch
from
b7f8f9f
to
067f957
Compare
NullVoxPopuli
approved these changes
Nov 17, 2018
|
Changes look good to me. Our CI is currently failing (for other reasons) :( |
ppcano
force-pushed
the
mu-new-blueprint-files
branch
from
067f957
to
a420a65
Compare
|
Rebased to trigger a new CI build, but it is still failing. |
|
@ppcano it looks like the test failures on TravisCI are related to the change in this PR |
ppcano
force-pushed
the
mu-new-blueprint-files
branch
from
a420a65
to
086c399
Compare
|
@Turbo87 You are right; I didn't run the tests with the Would you accept additional PRs to attempt to homogenize the MU/ Non-MU tests? |
Turbo87
approved these changes
Nov 29, 2018
sure, sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #7530
Assuming that
unitandintegrationtests should be placed where its "tested" class is located, there is no need to auto-generate thetests/{unit,integration}folders anymore.The PR will make the
blueprintto stop adding these folders, but it will generate atests/acceptancefolder instead.