New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade `ember-source` for MU new blueprints #8317

Merged
merged 1 commit into from Dec 23, 2018

Conversation

Projects
None yet
2 participants
@ppcano
Copy link
Contributor

ppcano commented Dec 23, 2018

Closes #8316

The blueprint should point to the most recent canary tarball (via ember-source-channel-url). We need to use canary specifically because MU requires a feature flag to be enabled which is only possible in canary builds.

The last upgrade was done by #7976

@rwjblue
Copy link
Contributor

rwjblue left a comment

This looks good, thank you!

Perhaps in a follow up PR, we could tweak the blueprint to actually fetch the latest each time. What do you think?

@ppcano

This comment has been minimized.

Copy link
Contributor Author

ppcano commented Dec 23, 2018

I thought about that too when reviewing https://github.com/ember-cli/ember-octane-blueprint/blob/master/index.js, but this change will likely require to change some ember-cli tests.

As you see in the PR the test fixtures are also changed because the content of the npm/yarn file is compared and validated.

I am not sure atm how to change the tests if the ember-sourcevalue is dynamically fetched.

We follow the same approach when upgrading the ember-source of the Classic app as show at a824605

@rwjblue

This comment has been minimized.

Copy link
Contributor

rwjblue commented Dec 23, 2018

I am not sure atm how to change the tests if the ember-sourcevalue is dynamically fetched.

If you take a look here, we already do a custom matcher for package.json so taht we can account for dynamic ember-cli versions, I think this function can fairly easily be extended to support custom ember-source version. What do you think?

function checkPackageJson(fixtureName) {

@rwjblue rwjblue merged commit 1bd7ea2 into ember-cli:master Dec 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 90.519%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment