Migrate supported Node version detection to use GitHub Actions config. #9093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
update-support-detection
branch
from
f9a64a3
to
2722d47
Compare
kellyselden
approved these changes
Mar 14, 2020
The `PlatformChecker` reads the Node versions that are being tested in
CI to decide if we should print a message to the console upon booting.
When running on a supported (based on our `package.json`'s
`engines.node`) but untested (e.g. not tested in CI) the following
message is printed:
> Node ${process.version} is not tested against Ember CLI on your
> platform. We recommend that you use the most-recent "Active LTS"
> version of Node.js. See https://git.io/v7S5n for details.
However, when running on an unsupported version of Node (e.g. a version
not covered by our `package.json`s `engines.node`) the following message
is printed:
> Node ${process.version} is no longer supported by Ember CLI.
> We recommend that you use the most-recent "Active LTS"
> version of Node.js. See https://git.io/v7S5n for details.
---
This change updates the `PlatformChecker` to use the GitHub Actions
configuration (`.github/workflows/ci.yml`) instead of using
`.travis.yml` and `appveyor.yml`.
rwjblue
force-pushed
the
update-support-detection
branch
from
2722d47
to
d93e4ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PlatformCheckerreads the Node versions that are being tested in CI to decide if we should print a message to the console upon booting.When running on a supported (based on our
package.json'sengines.node) but untested (e.g. not tested in CI) the following message is printed:However, when running on an unsupported version of Node (e.g. a version not covered by our
package.jsonsengines.node) the following message is printed:This change updates the
PlatformCheckerto use the GitHub Actions configuration (.github/workflows/ci.yml) instead of using.travis.ymlandappveyor.yml.