Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate supported Node version detection to use GitHub Actions config. #9093

Merged
merged 1 commit into from
Mar 14, 2020

Commits on Mar 14, 2020

  1. Migrate supported Node version detection to use GitHub Actions config.

    The `PlatformChecker` reads the Node versions that are being tested in
    CI to decide if we should print a message to the console upon booting.
    
    When running on a supported (based on our `package.json`'s
    `engines.node`) but untested (e.g. not tested in CI) the following
    message is printed:
    
    > Node ${process.version} is not tested against Ember CLI on your
    > platform. We recommend that you use the most-recent "Active LTS"
    > version of Node.js. See https://git.io/v7S5n for details.
    
    However, when running on an unsupported version of Node (e.g. a version
    not covered by our `package.json`s `engines.node`) the following message
    is printed:
    
    > Node ${process.version} is no longer supported by Ember CLI.
    > We recommend that you use the most-recent "Active LTS"
    > version of Node.js. See https://git.io/v7S5n for details.
    
    ---
    
    This change updates the `PlatformChecker` to use the GitHub Actions
    configuration (`.github/workflows/ci.yml`) instead of using
    `.travis.yml` and `appveyor.yml`.
    rwjblue committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    d93e4ee View commit details
    Browse the repository at this point in the history