Make configuration work in engines #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fix-in-engines
branch
from
769789e
to
3506873
Compare
rwjblue
approved these changes
Nov 27, 2018
nlfurniss
reviewed
Nov 27, 2018
| app = current.app || this; | ||
| } while (current.parent && current.parent.parent && (current = current.parent)); | ||
|
|
||
| return app; |
There was a problem hiding this comment.
Since this functionality is in cli > 2.17 an this addon uses at least 3.5, seems like we can remove this?
There was a problem hiding this comment.
@nlfurniss This supports consumer app whose cli <= 2.17
There was a problem hiding this comment.
But given the current version of this addon tests against 3.5, we dont really support < 2.17...
There was a problem hiding this comment.
We lack a way to test against different cli versions
tomdale/ember-cli-addon-tests#25
This makes sure that all nested dependencies use the correct application configuration, and that the import/configuration works in nested addons, especially in engines.
mydea
force-pushed
the
fix-in-engines
branch
from
3506873
to
e09bd95
Compare
|
I have rebased 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that all nested dependencies use the correct application configuration, and that the import/configuration works in nested addons, especially in engines.
This fixes #133.
I tried it in an app of ours with engines & nested dependencies to ember-fetch, and this ensures that it always got the correct options passed.
Note: While investigating this, I also found out that it wasn't even taking the correct options for building. E.g. If, in my engines dummy app, I had
preferNative: truespecified in theember-cli-build.js, it never actually got to this value, instead reading the config from ember-fetch's config (somehow? not entirely sure).