Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ember-data adapter mixin #308

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Deprecate ember-data adapter mixin #308

merged 2 commits into from
Jun 28, 2019

Conversation

xg-wang
Copy link
Member

@xg-wang xg-wang commented May 23, 2019

Fixes #289

nlfurniss
nlfurniss requested changes May 23, 2019
View reviewed changes
addon/utils/determine-body-promise.ts Outdated Show resolved Hide resolved
@xg-wang
Copy link
Member Author

xg-wang commented Jun 14, 2019

@nlfurniss @rwjblue can you review?

@nlfurniss
Copy link
Collaborator

LGTM

@xg-wang xg-wang merged commit f7d17be into ember-cli:master Jun 28, 2019
@xg-wang xg-wang deleted the deprecate branch June 28, 2019 02:39
@xg-wang xg-wang changed the title Deprecate ember-data support utils Deprecate ember-data adapter mixin Jun 28, 2019
@rwjblue
Copy link
Member

rwjblue commented Jun 28, 2019

Thank you @xg-wang and @nlfurniss, sorry for the super delay in responding here...

@mydea mydea mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlfurniss nlfurniss nlfurniss approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate + Remove Ember Data Functionality
3 participants
@xg-wang @nlfurniss @rwjblue