Pass Referrer to Glimmer Resolver #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2017
iezer
force-pushed
the
isaac/pass-referrer
branch
2 times, most recently
from
5a81ab1
to
db93047
Compare
mixonic
reviewed
Jun 25, 2017
| let appName = this.config.app.name; | ||
| let parts = referrer.split(':src/ui/'); | ||
| referrer = `${parts[0]}:/${appName}/${parts[1]}`; | ||
| referrer = referrer.split('/template.hbs')[0]; |
There was a problem hiding this comment.
An aside, but @dgeb thinks @wycats and @chancancode are perhaps working on adding the absolute specifier to the template meta a compilation time. One that work lands we could change Ember to pass that and this code goes away 👍
iezer
force-pushed
the
isaac/pass-referrer
branch
from
db93047
to
531d41c
Compare
|
Closed in #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required for local lookup
Related PRs: