Normalize referrer and lookupString, add config flag #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
commented
Jul 1, 2017
| if (lookupString.indexOf('template:components/') === 0) { | ||
| if (referrer) { | ||
| // make absolute | ||
| let appName = this.config.app.rootName; |
There was a problem hiding this comment.
Should this be app.name or app.rootName?
mixonic
commented
Jul 1, 2017
| if (lookupString.indexOf('template:components/') === 0) { | ||
| if (referrer) { | ||
| // make absolute | ||
| let appName = this.config.app.rootName || 'app'; |
There was a problem hiding this comment.
mixonic
force-pushed
the
pass-referrer-v2
branch
4 times, most recently
from
6d99bfa
to
ddac8d3
Compare
|
With updates re: glimmerjs/glimmer-resolver#17 (comment) |
* The referrer from Ember is not an absolute specifier. Do some string munging to clean it up. We would like this to be a build step on Ember template compilation at some point. * Ember tries to namespace components with `components/` as a specifier namespace. Drop that, since MU rules say to look in the components collection anyway. * Resolve with only a bare type and a referrer to look up route templates. * Bump @glimmer/resolver
This was referenced Jul 2, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
munging to clean it up. We would like this to be a build step
on Ember template compilation at some point.
components/as a specifiernamespace. Drop that, since MU rules say to look in the components
collection anyway.
Supersedes #196, compatible with glimmerjs/glimmer-resolver#17