Use build-time project.isModuleUnification() instead of feature flag.
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
force-pushed
the
use-build-time-module-unification-check
branch
2 times, most recently
from
367f1ef
to
0087eff
Compare
This allows classic apps to NOT ship the MU resolver code
cibernox
force-pushed
the
use-build-time-module-unification-check
branch
from
0087eff
to
2620d96
Compare
|
I tested this in MU and non MU apps and I discovered a but, bit it's working now. |
rwjblue
reviewed
Mar 15, 2018
| }, resolverConfig.features); | ||
| }, | ||
|
|
||
| init: function() { | ||
| this._super.init.apply(this, arguments); | ||
| this.options = this.options || {}; | ||
|
|
||
| if (process.env.EMBER_RESOLVER_MODULE_UNIFICATION) { | ||
| this.project.isModuleUnification = function () { |
There was a problem hiding this comment.
This seems fairly odd to me. Why do we have to monkey patch this?
There was a problem hiding this comment.
For testing the MU scenario in Travis only. See https://github.com/ember-cli/ember-resolver/blob/master/config/ember-try.js#L17
Any suggestion on an alternative approach? I find this relatively clean.
|
Thank you @cibernox!!! This is great. |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows classic apps to NOT ship the MU resolver code.