-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next design iteration #400
Comments
Wouldn't it be a bit of uncomfortable for laptop screens? they aren't specially big, you know 😔 |
@HenryVonfire you mean height right? I think the main question is how big the code snippets wil generally get. This is the current app in +- 1400px, personally I'm not sure whether narrow columns are better. |
@joostdevries yes, I mean the height. In jsfiddle for example, I find pretty annoying to be resizing the views because the html view is bigger than the javascript view (or vice versa), or having the css view open when I'm not using it at all. Also, in my opinion the output view should be bigger since it's the result of whatever you are doing in the twiddle. For example, tables tend to need a lot of space (imagine that you are playing around with Have you considered using tabs? |
@HenryVonfire understood! Tabs are another alternative I was thinking about but I think that's actually quite similar to how we handle it now. (except that instead of tabs we have dropdowns). |
@joostdevries well, something like cloud9 would be great but I don't think that level of complexity is required. The tree view allows to access easily any file and tabs make easier to switch context without losing space. Maybe would be nice to optionally allow the user to create an extra view (vertical or horizontal) that can contain tabs in it (for those people that like to have different files opened at the same time). Again this is just my opinion and totally based on my experiences 😄 |
I'd much prefer to avoid the "quadrant" style of JSFiddle. It would be nice to close the output window (or have it be a second tab) so that you could focus more on writing the code until it should be ran.... |
I absolutely love the concept @joostdevries posted. I think it fits much better with how I actually use ember-twiddle – lots of small files open at once, file tree small but all files visible in it. I really hope we get towards something like that. @rwjblue maybe a button & shortcut to fill screen with current editor to focus on it would alleviate that? |
I would suggest something like this (based on @joostdevries's idea): Things to remark:
|
@HenryVonfire I like most of that, but I really wouldn't want to lose side-by-side editing. Editing more than one file at a time is crucial in ember and I personally would love to have more of it, not less ;) |
@HenryVonfire @alexspeller I think that based on your input I can probably create something to satisfy both. |
Every dropdown is under Why remove gravatar? |
Next iteration.
|
I'd put those at the bottom of the first orange block, so you'd have something like
(because those actions like save apply to the whole of this twiddle, like admin actions) |
I would also move down the save button at the same level that Fork/Delete are. |
from @locks in slack:
|
Yeah that makes sense, I guess adding the buttons next to the existing ones is easy but maybe if there are too many, do something like the chrome devtools does for choosing vertical / horizontal?
Use an intelligent string matching algorithm like TextMate, Sublime or even Github when you press
It could, but I quite like it where it is - it's applying to that side, it's just a view thing not a global twiddle state control thing. But I don't really care that much about it, it could go anywhere really. |
Hello Everyone, my comments here from the stuff reviewed/commented by the rest of the people:
Attached you'll see a design i've been working. I've also created a brand, which i like a lot, that can be used if you guys like it, the main idea was to have a Tomster, but in a more digital/squarish shape, shows its part of ember but at the same time holds a particular shape related only to Twiddle, and more importantly due to the shape/form can be used in small sizes that will be easily recognisable, for instance when embedding code, in the header of the embedded module. The main goal is to have a clean, easy to read design, to focus on writing your code. Also i think theres the need to create at least a small styleguide for colors, fonts, and so on, mostly for the shape of the embed code and the buttons that potentially the module can hold. All comments and improvements are more than welcome, lets tear this apart. |
Beautiful mockups @matmac |
I'd love to tackle some of this, can you provide the assets, i.e. logo, fonts, icons? |
As a user I'd find it way more valuable if Addons worked. There may be wins from a UI refactor, but until what I think is a fundamentally Ember feature is well supported, I'm not sure i'd get any more value from the tool with a redesign. |
@lukesargeant the redesign is 95% finished lol, see #490. Just need to take the tests over the hump and fix any discovered bugs. I do agree with addons being a highly requested feature, but I neither had the time or knowledge to do that, so I started here. |
Cool. My apologies for not seeing the PR whilst looking through the issues. If it’s in full flight then it’s totally worth finishing :-) |
how about https://codesandbox.io/ like environment which enables dowloading the snippet as a new ember app which can be run on user's machine and may be on the fly deploy! #JustAThought |
@gokatz it already exists: |
yeah, I noticed that. I mean something like,
|
That would be sweet |
We've added quite a lot of functionality to Twiddle over the past months. I think now would be a good time to look into how we can streamline all these functionalities and make the UI a bit cleaner.
Formats
Low-level issues:
High-level stuff:
User stories
The text was updated successfully, but these errors were encountered: