Addonify++ #64
Merged
Addonify++ #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, `addon/` is used for ES6 source, but this addon is the supporting loader so it cannot actually be in ES6 format.
The move of the entry point script and dropping support for `bower` consumers is a breaking change. Update version number accordingly.
Closed
|
@stefanpenner - r? |
|
Updates to ember-cli being tracked in ember-cli/ember-cli#5379. |
|
|
||
| included: function() { | ||
| this.app.import('vendor/loader.js', { | ||
| prepend: true |
There was a problem hiding this comment.
is this sufficient, or should we make a special case option for the loader itself?
There was a problem hiding this comment.
This ensures loader is prepended, in theory other things could also ask to be prepended today but they would already be added before the loader.
Basically, things that are prepended to vendor should not assume the loader works (this is how it is today also)...
|
@rwjblue seems good. r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.