New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move loader.js to be included as an addon. #5379
Conversation
929d32c
to
bfd1128
Compare
ember-cli/loader.js#64 was released as v4.0.0, rebasing this PR to include it. |
da49dd0
to
1e50818
Compare
☔ The latest upstream changes (presumably #5367) made this pull request unmergeable. Please resolve the merge conflicts. |
I would prefer that the prepend check for this to be special-cased. That way in an ideal scenario it's:
That makes the way I'm thinking about service workers a lot easier. Note: I don't want to let perfect be the enemy of good, if we're comfortable going back and adding this when necessary, let's ship this as is. (Pretty sure that would be backwards compatible too.) |
@nathanhammond and I discussed this at length in #dev-ember-cli. The current plan of attack is to:
I am going to continue this PR and try to get it in a mergeable state (there are a couple addon tests failing ATM), and then follow this PR up with points 1 through 3 from above as a separate PR (that either @nathanhammond or I will work on tonight/tomorrow). |
242b1ab
to
96a0f13
Compare
This allows us to: * Remove another bower dependency * Ensure that ember-cli is properly paired with the loader.js version * Remove reexporter code, since we now know for certain what loader.js we have.
96a0f13
to
8c4ae3e
Compare
👍 |
Move loader.js to be included as an addon.
This allows us to:
Requires ember-cli/loader.js#64.