Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when running consuming app in dev mode, fine in prod mode #24

Closed
kybishop opened this issue Nov 4, 2017 · 2 comments
Closed

Crash when running consuming app in dev mode, fine in prod mode #24

kybishop opened this issue Nov 4, 2017 · 2 comments

Comments

@kybishop
Copy link

kybishop commented Nov 4, 2017

Uncaught TypeError: Cannot read property 'length' of undefined
    at _loop (validation-decorator.js:61)
    at Function.create (validation-decorator.js:93)
    at Function.superWrapper (ember-utils.js:437)
    at Function.create (validated-component.js:27)
    at Function.superWrapper [as create] (ember-utils.js:437)
    at FactoryManager.create (container.js:391)
    at Proxy.create (container.js:135)
    at CurlyComponentManager.create (curly.js:178)
    at runtime.js:1671
    at AppendOpcodes.evaluate (runtime.js:70)

Tracks down to here: https://github.com/ember-decorators/argument/blob/master/addon/-debug/utils/validation-decorator.js#L64

This breaks dev mode for my own app, which depends on ember-attacher (which uses ember-popper)

@pzuraq
Copy link
Contributor

pzuraq commented Nov 4, 2017

Out of curiosity, what are your targets? Locally this transpiled to using Object.keys so it’s weird that the behavior is different here. Either way, thanks for the fix!

@pzuraq
Copy link
Contributor

pzuraq commented Nov 4, 2017

Fixed by #26

@pzuraq pzuraq closed this as completed Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants