Add exclude list to addon dedupe logic #804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is cobbled together from a JIRA ticket, so it is a bit fragmented.
Summary
When addons try to access
ember-cli-babel
during the build stage,EMBER_ENGINES_ADDON_DEDUPE=true
can causethis.addons
to be empty. Instead of requiring addons to do something likethis.addons.find(...) || this.project.addons.find(...)
, we should excludeember-cli-babel
from dedupe logic so it's available.Related code in ember-engines:
ember-engines/packages/ember-engines/lib/engine-addon.js
Line 845 in e247643
ember-engines/packages/ember-engines/lib/engine-addon.js
Lines 397 to 417 in e247643
cc: @rwjblue @brendenpalmer