-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement naive meta tag support #49
Conversation
@jpadilla ❤️ Looks great. Some ideas for additional support:
|
@gdub22 👍 for supporting supporting What is the use case for updating |
@gcollazo you are right about the crawler, it would just be nice to keep them in sync. Thinking about it more, it would be good to have this as an addon where you could define meta for each route, (https://github.com/ronco/ember-cli-meta-tags is a start) and fastboot just provides an injection point. Kinda how the title works now with https://github.com/kimroen/ember-cli-document-title |
This is great idea. I'd love to see it support arbitrary head content. |
I second this. I'll need to be able to inject additional scripts into the head dynamically and would love for this to be generic enough to support all head content. |
I would prefer tweaking simple-dom here to add: this.head = new Element('head'); Then we can handle arbitrary head content here.... |
@rwjblue btw this is ready for another look whenever you get the chance. |
Tests are currently not passing, since we'd need ember-fastboot/simple-dom#12 to be merged. |
This assumes we're able to merge ember-fastboot/simple-dom#12
@jpadilla Any progress? I can help out if it's a time thing. |
@jasonmit feel free to pick up. There's probably just a few things left after the simple-dom update. |
Are there updates on this? |
@esistgut I was actually planning on taking a crack at finishing it up this evening. |
Closed in favor of #114 |
* Update Node version matrix in Travis config. Node 0.11 should not be supported, and we should test against current stable version. * Ensure `port` is specified to `app.listen`. Node < 6.0 allows `port` to be `null` / `undefined` and automatically selects a port for you, in Node 6.0 this is an error.
…upport-matrix Update node support matrix
After hearing about Dockyard's new site using fastboot, we wanted to take it out for a spin on a new project. We noticed it wasn't yet possible to set meta tags like
description
. This allows setting meta tags similar to how we can set the document's title.This obviously still feels hacky but seems to work just fine so we decided to share and hopefully get some feedback.
Update: With a few simple tweaks this and #23 can play nicely together.