-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use -in-element
to render at appropriate time
#37
Changes from 1 commit
51ac068
6efeccf
c3168d4
d6402c0
1fc2703
9b1fad8
5dc82a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
<meta name="ember-cli-head-start">{{head-content}}<meta name="ember-cli-head-end"> | ||
{{#-in-element headElement}} | ||
<meta name="ember-cli-head-start">{{head-content}}<meta name="ember-cli-head-end"> | ||
{{/-in-element}} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,6 +26,7 @@ | |
"ember-cli-app-version": "^1.0.0", | ||
"ember-cli-dependency-checker": "^1.3.0", | ||
"ember-cli-eslint": "^3.0.0", | ||
"ember-cli-fastboot": "^1.0.2", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this is added as a devDependnecy? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Primarily to ensure this approach worked in fastboot. Means that we can run There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Definitely makes for easier local testing. Not sure if there are any ramifications to the ember-cli-addon-tests? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not an issue but I think you could write the tests in |
||
"ember-cli-htmlbars": "^1.1.1", | ||
"ember-cli-htmlbars-inline-precompile": "^0.4.0", | ||
"ember-cli-inject-live-reload": "^1.4.1", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
{{head-layout}} | ||
|
||
<h2 id="title">Welcome to Ember</h2> | ||
|
||
{{outlet}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - We have started taking steps to make this public API from the Glimmer VM perspective (see glimmerjs/glimmer-vm#619). It is unclear what Ember version that PR will correspond to, but it is a good step forward for our use case (and shows a future where we can drop the private
-
prefix).