Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the ember-cli logo above the TOC #81

Open
2 tasks
mansona opened this issue Dec 11, 2018 · 3 comments
Open
2 tasks

Show the ember-cli logo above the TOC #81

mansona opened this issue Dec 11, 2018 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@mansona
Copy link
Member

mansona commented Dec 11, 2018

For the cli-guides we should show the ember-cli logo in the top left just above the TOC.

screenshot 2018-12-11 at 11 18 08

As we are using guidemaker for the ember-cli guides we will need to make this a configurable feature of the guidemaker-ember-template so that any other projects using the same template can optionally configure this logo

Todo

@mansona mansona added the help wanted Extra attention is needed label Dec 11, 2018
@mansona mansona changed the title Show the ember-cli logo instead of the generic Ember logo Show the ember-cli logo above the TOC Dec 11, 2018
@villander
Copy link
Contributor

@mansona I don't understand this question. Where are this logo? do you want me to put it in guidemaker-ember-template? and make it configurable?

@mansona
Copy link
Member Author

mansona commented May 15, 2019

@villander yes this would be a change to guidemaker-ember-template and it would need to be configurable (so it doesn't show up in other sites that use this template)

@ijlee2 ijlee2 removed the DecEmber label Sep 22, 2020
@cah-john-ryan
Copy link

Hi @mansona,

In looking through this I see that the logo exists at https://github.com/emberjs/website/blob/master/source/images/brand/ember_CLI-Light.png.

Are you ok with me creating a copy of this here: https://github.com/ember-learn/guidemaker-ember-template/tree/master/public/images/logos? I don't readily know how else I can make this asset available in the guidemaker repo without porting it over.

Regardless. I plan to try and assemble PR's for this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants