-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert cli-guides to be a single repo project #28
Conversation
0489d15
to
5923f26
Compare
5923f26
to
15ebad7
Compare
f528531
to
d9ea8bd
Compare
For anyone who wants to have a look at the deploy-preview it's here: https://deploy-preview-28--ember-cli-guide.netlify.com I think the name of the app was changed since the build notification was added ☝️ |
app/index.html
Outdated
<head> | ||
<meta charset="utf-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<title>CliGuidesSource</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<title>CliGuidesSource</title> | |
<title>Ember CLI Guides</title> |
Also, let's update the README.md with the new simple instructions to running the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. @locks ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran locally, looks good 👍 ! Excited to be able to have review apps.
Howdy folks 👋
When we set up the cli-guides-source it was using a very early version of Guidemaker that required the source and the app to be in different repos. This is because of the fact that Guidemaker is essentially an extraction of the tech behind the Ember Guides App and that was one of the original design principles of that project.
Having different repos was useful in some regards but caused a number of issues:
This PR solves all of these problems, and as a bonus you will be able to see a netlify demo of this PR to show you what it looks like 🎉
I am happy to discuss this some more if anyone has any questions 👍