Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar text update - Clarify that API docs are for Ember #129

Closed
wants to merge 1 commit into from

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Dec 6, 2018

As noted in ember-learn/cli-guides#65, "API Reference" is ambiguous. API for what? This changes it to "Ember.js API Reference," and "CLI Guides and API."

Thoughts?

@MelSumner
Copy link
Member

@jenweber I thought we were doing a separate one for CLI API? I don't think we should mush guides and APIs together.

@MelSumner
Copy link
Member

Per our sitemap- we're putting all of the 3 main APIs together and the guides will be separate.
If we change anything, we should group the guides, then have a separator, then have the API link. Reference: https://github.com/ember-learn/handbook/blob/master/website_sitemap.md.

@MelSumner MelSumner closed this Dec 12, 2018
@jenweber jenweber deleted the default-links branch December 15, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants