Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove jQuery from component lifecycle #200
referenced this pull request
Oct 8, 2018
I worked on this too, missed you had put this together! I'm happy to use yours, but here are my notes based on my work on it...
It would be helpful to have a twiddle that shows that these selectors work as shown in the guides.
I also added on small edit for a url. Thank you!
Hi! This PR was still open as of creating the 3.5 release. This means before this PR to be merged, any changes requested should be made, and then the same additions should be applied to the upcoming 3.5 version files. They will be available later this week. Sorry about the extra step!
@jenweber Sorry about the delay. I've updated the exaples and copied the changes over to the 3.5.0 files. Maybe you want me to revert the 3.4.0 files, so that we only update the released guides?
I have also made an Ember Twiddle that shows that some of these things work as expected: https://ember-twiddle.com/c8c9f62aa2bc9f7807edf89f8b246bfe?numColumns=2&openFiles=components.my-component.js%2Ctemplates.components.my-component.hbs
I will update the twiddle with an example component for the more complex examples we have in these files.
Let me know if there's anything else you want me to do in this PR!