Interop with EmberObject.extend on < 3.1 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
force-pushed
the
2-18-subclass
branch
2 times, most recently
from
3696183
to
f1f91f5
Compare
rwjblue
force-pushed
the
2-18-subclass
branch
from
f1f91f5
to
3715c88
Compare
|
Rebased on master to get CI to run (needed e3262c1). |
chancancode
added a commit
to sukima/ember-class-based-modifier
that referenced
this pull request
Sep 20, 2019
Now that ember-polyfills/ember-modifier-manager-polyfill#11 is merged and released, we should be able to support 2.18 now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe emberjs/ember.js#16757 was what made it work on 3.1+.