Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CoreObject rely more on ES2015 class features and interop better. #16757

Merged
merged 8 commits into from Jun 21, 2018

Conversation

krisselden
Copy link
Contributor

No description provided.

@krisselden
Copy link
Contributor Author

the last commit has more than is needed to workaround the issue.

all that is actually needed is DefaultResolver.create = function create(props) { return new this(props); };

For some reason props is becoming undefined when it hits the CoreObject.create intermittently in some test cases.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I’d generally like to get a bug reported to the FF folks, but I think as long as we have that we can land. The current canary cycle is another few weeks and then we have a full beta cycle, which should be plenty time for a “shake down”...

@rwjblue
Copy link
Member

rwjblue commented Jun 20, 2018

I guess maybe we should also add another test (or few tests) to the ES compatibility test suite for things that wouldn't have worked before, but do work with these changes...

@rwjblue rwjblue merged commit d424af0 into master Jun 21, 2018
@rwjblue rwjblue deleted the core-object-extend branch June 21, 2018 19:38
rwjblue added a commit that referenced this pull request Jun 21, 2018
Make CoreObject rely more on ES2015 class features and interop better.

(cherry picked from commit d424af0)
krisselden added a commit that referenced this pull request Jun 21, 2018
Make CoreObject rely more on ES2015 class features and interop better.

(cherry picked from commit d424af0)
krisselden added a commit that referenced this pull request Jun 22, 2018
Make CoreObject rely more on ES2015 class features and interop better.

(cherry picked from commit d424af0)
krisselden added a commit that referenced this pull request Jun 25, 2018
Make CoreObject rely more on ES2015 class features and interop better.

(cherry picked from commit d424af0)
krisselden added a commit that referenced this pull request Jun 26, 2018
Make CoreObject rely more on ES2015 class features and interop better.

(cherry picked from commit d424af0)
@DLiblik
Copy link

DLiblik commented Sep 26, 2018

I've noticed that EmberObject.create(null) no longer works - was this intended? If not, I will open a separate issue. We had some code break as a result when we were initializing simplified objects.

@rwjblue
Copy link
Member

rwjblue commented Sep 26, 2018

@DLiblik - Hmm, I'm not sure I can reason about what that should have done. Feel free to open a new issue and we can discuss it (pretty likely to get lost as a comment on an old PR...).

@DLiblik
Copy link

DLiblik commented Sep 27, 2018

@rwjblue Thanks - my understanding is that it creates an object without standard superclass properties - I think there's been a dialog over at #15001 (Drop EmptyObject and use Object.create(null) again). But it's not clear to me what the actual design decision was in either case - opening a new issue to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants