Skip to content

Commit

Permalink
Remove eslint-plugin-import-helpers
Browse files Browse the repository at this point in the history
eslint-plugin-import-helpers@1 requires Node 16 or higher, which is not
compatible with our node support matrix. In version 1.3.0 they added an
`engines` field documenting that requirement. When using `npm@8` the
`--engines-strict` flag is on by default. Ultimately, this combination
of events means that `npm ci` fails with:

```
❯ volta run --node=14.x --npm=8.10.0 npm ci
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: eslint-plugin-import-helpers@1.3.0
npm ERR! notsup Not compatible with your version of node/npm: eslint-plugin-import-helpers@1.3.0
npm ERR! notsup Required: {"node":"> 14"}
npm ERR! notsup Actual:   {"npm":"8.10.0","node":"v14.20.1"}

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/rjackson/.npm/_logs/2022-10-25T20_45_44_753Z-debug-0.log
```
  • Loading branch information
rwjblue committed Oct 26, 2022
1 parent 9e99852 commit 2290459
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 43 deletions.
23 changes: 1 addition & 22 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,7 @@ module.exports = {
env: {
node: true,
},
plugins: [
'eslint-comments',
'filenames',
'import',
'import-helpers',
'node',
'prettier',
'unicorn',
],
plugins: ['eslint-comments', 'filenames', 'import', 'node', 'prettier', 'unicorn'],
extends: [
'eslint:recommended',
'plugin:eslint-comments/recommended',
Expand Down Expand Up @@ -101,19 +93,6 @@ module.exports = {
'import/no-webpack-loader-syntax': 'error',
'import/unambiguous': 'error',

'import-helpers/order-imports': [
'error',
{
newlinesBetween: 'always',
groups: [
'/^(assert|async_hooks|buffer|child_process|cluster|console|constants|crypto|dgram|dns|domain|events|fs|http|http2|https|inspector|module|net|os|path|perf_hooks|process|punycode|querystring|readline|repl|stream|string_decoder|timers|tls|trace_events|tty|url|util|v8|vm|zli)/',
['module'],
['parent', 'sibling', 'index'],
],
alphabetize: { order: 'asc', ignoreCase: true },
},
],

// Jest rules:
'jest/no-conditional-expect': 'off',

Expand Down
20 changes: 0 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-filenames": "^1.3.2",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-import-helpers": "^1.3.0",
"eslint-plugin-jest": "^26.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^4.2.1",
Expand Down

0 comments on commit 2290459

Please sign in to comment.