Skip to content

Commit

Permalink
Remove usage of cross-env
Browse files Browse the repository at this point in the history
We were using `cross-env` in order to set the
`--experimental-vm-modules` flag via `process.env.NODE_OPTIONS` to run
`jest`. Unfortunately, this means that the `NODE_OPTIONS` that was being
set in our `.github/workflows/ci.yaml` (which increases
`--max-old-space-size` to 4096) is completely clobbered.

This doesn't **fix** the memory issues that we are seeing with Node 18,
but it does bring back a previously known good work around so that CI is
"green again".

Co-authored-by: Steve Calvert <steve.calvert@gmail.com>
  • Loading branch information
rwjblue and scalvert committed Oct 27, 2022
1 parent 00fdbc8 commit c42b0b2
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"new:rule": "node dev/generate.js new-rule",
"release": "release-it",
"test": "npm-run-all lint:* test:*",
"test:jest": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --coverage",
"test:jest:watch": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --watch",
"test:jest": "node --experimental-vm-modules ./node_modules/jest/bin/jest.js --coverage",
"test:jest:watch": "node --experimental-vm-modules ./node_modules/jest/bin/jest.js --watch",
"update": "npm-run-all update:*",
"update:indices": "node ./scripts/update-indices.js",
"update:readme": "node ./scripts/update-readme.js"
Expand Down Expand Up @@ -90,7 +90,6 @@
"@microsoft/jest-sarif": "^1.0.0-beta.0",
"@scalvert/bin-tester": "^2.1.0",
"common-tags": "^1.8.2",
"cross-env": "^7.0.3",
"eslint": "^8.25.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-eslint-comments": "^3.2.0",
Expand Down

0 comments on commit c42b0b2

Please sign in to comment.