Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check embedded templates by default #2601

Closed
rwjblue opened this issue Aug 31, 2022 · 0 comments · Fixed by #2606
Closed

Check embedded templates by default #2601

rwjblue opened this issue Aug 31, 2022 · 0 comments · Fixed by #2606
Labels
breaking
Milestone
5.0.0

Comments

@rwjblue
Copy link
Member

rwjblue commented Aug 31, 2022

Support for checking embedded templates was added in #2483, but .js/.ts/.gjs/.gts files are excluded by default in that PR (in order to be able to land it as part of a non-breaking 4.x release).

As we plan for 5.0 we should ensure that we remove the --ignore-patterns added for those embedded template extensions.
@rwjblue rwjblue added this to the 5.0.0 milestone Aug 31, 2022
@bmish bmish mentioned this issue Sep 1, 2022
Closed
NullVoxPopuli added a commit to NullVoxPopuli/ember-template-lint that referenced this issue Sep 1, 2022
@NullVoxPopuli
Resolve ember-template-lint#2601, support the SUPPORTED_EXTENSIONS
653869a
@NullVoxPopuli NullVoxPopuli mentioned this issue Sep 1, 2022
Merged
NullVoxPopuli added a commit to NullVoxPopuli/ember-template-lint that referenced this issue Sep 2, 2022
@NullVoxPopuli
Fixes ember-template-lint#2601 -- support the SUPPORTED_EXTENSIONS
809150a 
Link: ember-template-lint#2601
@bmish bmish closed this as completed Nov 3, 2022
@bmish bmish mentioned this issue Dec 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Lint embedded templates by default NullVoxPopuli/ember-template-lint
2 participants
@rwjblue @bmish