Implement support for embedded templates #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ventuno
force-pushed
the
implement-support-embedded-templates
branch
from
93394ea
to
17e1946
Compare
added 10 commits
April 24, 2022 19:16
ventuno
force-pushed
the
implement-support-embedded-templates
branch
from
9069f66
to
4fa83d0
Compare
NullVoxPopuli
approved these changes
Apr 25, 2022
rwjblue
requested changes
Apr 26, 2022
rwjblue
reviewed
Apr 27, 2022
rwjblue
requested changes
Apr 27, 2022
ventuno
requested review from
rwjblue,
chriskrycho and
NullVoxPopuli
and removed request for
chriskrycho and
NullVoxPopuli
rwjblue
reviewed
Aug 26, 2022
ventuno
requested review from
rwjblue and
chriskrycho
and removed request for
chriskrycho and
rwjblue
rwjblue
approved these changes
Aug 30, 2022
bmish
changed the title
rwjblue
added a commit
to ember-template-imports/ember-template-imports
that referenced
this pull request
Oct 26, 2022
ember-template-lint@4.14.0 landed a direct import of this file as `import * as util from 'ember-template-imports/src/util.js';` (in ember-template-lint/ember-template-lint#2483), but #75 removed `src/utils.js` (migrating it to TypeScript). In order to prevent users from getting errors when getting a floating version of `ember-template-imports` that includes this file being rewritting in `.ts` we need to re-export from `lib/utils.js`. This should be removed in the next major version
This was referenced Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the work started in #2324