Ensures all log calls include node
#2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Aug 30, 2021
scalvert
commented
Aug 30, 2021
rwjblue
requested changes
Aug 31, 2021
Co-authored-by: Robert Jackson <me@rwjblue.com>
|
@rwjblue every time I accept your suggestion I'm cursed with a Prettier error. I wish GH could just Pretterify the suggestions! |
|
@rwjblue I think we're GTG. |
rwjblue
changed the title
node
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of #2072.
While this PR looks huge (and it is!), it's mostly procedural changes related to each rules' log calls. I've subdivided each one into a separate commit in which I made the change, independently ran each test to verify correctness, and committed. The main change to take a look at is the logic in
log, where we're now merging with potentially overridden values passed in tolog.Additionally, a new deprecation warning has been added to
logto ensure consumers can migrate their rules in plugins without concern for them breaking. If using incorrect log usage in local rules, this deprecated usage willthrowduring tests.