Tweak ordering of items in v4 migration guide #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
added a commit
that referenced
this pull request
Jan 5, 2022
* Extend `no-bare-strings` rule to include `page-title` helper * Draft a migration guide for v4 * Set new Nodejs support matrix It will allow to use pure ESM dependencies (which are quickly becoming commonplace) and other new Node features like node: prefix imports * Use native flatMap (removing polyfill) As it is now possible with the new Nodejs support matrix * volta: Use latest node12 * Remove deprecated createRequireFromPath It was deprecated in node@12.2.0 (https://nodejs.org/tr/blog/release/v12.2.0/ release notes) * Retire no-invalid-block-param-definition rule * breaking: delete rule deprecated-each-syntax * breaking: delete octane config * breaking: remove --json CLI option * chore: update internal linters including ESLint 8 * breaking: set allowEmptyLinks option default to false on no-invalid-link-text rule * Upgrade ember-template-recast to v6 Under the hood, this commit upgrades @glimmer/syntax v0.65.0 from to v0.83.0 * Add a test case for no-bare-strings * Change how no-bare-strings can be configured to match entities To allow an html entity, it will have to be specified as an entity and not as a character. * Extend `no-invalid-link-title` rule * Update `yargs` dependency * chore(dev-deps): update release-it-lerna-changelog to v4 * chore(deps): recreate lockfile * breaking: remove --print-pending option * breaking: add exports to package.json * breaking: add recommended rules for v4 * Upgrade template-recast to 6.1.0 * breaking: when logging a rule violation, require passing node or all loc properties * breaking: disallow unexpected properties in rule test cases * breaking: require fixable test cases to assert the fixed template * chore: remove useless rule exports * breaking: disallow unexpected properties at top-level of configuration file * breaking: remove config `2-x-recommended` and add `3-x-recommended` config * breaking: throw when extending invalid config * breaking: throw when encountering invalid plugin in config * breaking: only fixable test cases are allowed to assert fixedTemplate * breaking: disallow template and fixedTemplate from matching in a test case * breaking: change no-bare-strings rule options to augment instead of replace the default config * Release 4.0.0-alpha.0 * test: add test for logging a violation without node and without all loc properties * breaking: require message when logging rule violation * breaking: Removes deprecated pending functionality * Removing unnecessary config validation * Add a fixer for the `quotes` rule * Change acceptance tests about non-fixable rules to use a test helper Previously these tests were using the `quotes` rule to exercise behavior around non-fixer rules. Adding a fixer for the quotes rule then made these unrelated tests fail. Added a dedicated easy-to-control failing rule to the test helpers. * Don't fix quotes in cases where it would create invalid templates * add todo comment for blocked autofix * Updating to new single file storage for todos * Updating @ember-template-lint/todo-utils to alpha * Upgrade to @ember-template-lint/todo-utils@11.0.0-beta.0 * Adding --compact-todo option * Updating documentation * Detect whether old .lint-todo directory exists, error and exit * Explicitly setting exitCode * chore(deps): update yargs to 17.3.0 * breaking: add no-autofocus-attribute as recommended rule * chore(dev-deps): update eslint-plugin-unicorn to v39 * breaking: exit with error when passing non-existent file on CLI * Upgrading to beta.1 * chore: Updating to use @lint-todo/utils package * breaking: disallow unknown CLI options * Release 4.0.0-beta.0 * fix merge conflict * breaking: convert to esm * fix: Updates @lint-todo/utils to latest version for read isolation * breaking: disable requireActionHelper option on no-element-event-actions rule * breaking: disallow duplicate test cases * fix changelog ordering * Release 4.0.0-beta.1 * wip import plugin/config * fix async config loading in Linter class * fixtures import instead of require rule * wip cjs fixture files * fix plugin resolving for other file extensions * fix html tests and lint violations * fix print config test * fix shebang test * fix formatting in indices * fix lint * use ESM for scripts * test coverage * export NODE_OPTIONS for windows * fix NODE_OPTIONS for windows again * consistent default export * remove incorrect await * add async function to rejects expects * tweaks * add comments * add mjs extension config/plugin test * dev script to esm * improve comments * improve comments * fix mjs fixture test * use separate helper file instead of exporting functions from CLI binary script Ensures binary runs with or without passing it to Node. Removes need to check if binary is run directly or imported. * add await to expect rejects tests * test jest runInBand * Revert "test jest runInBand" This reverts commit 5de4747. * remove unnecessary CJS fallback for plugin/config loading * jest useFakeTimers * use fake timers except for long-running rule-test.js * Revert "remove unnecessary CJS fallback for plugin/config loading" This reverts commit ed1b32f. * Revert "use fake timers except for long-running rule-test.js" This reverts commit 14fe0ca. * Revert "jest useFakeTimers" This reverts commit 8a44de4. * remove yarn --ignore-engines * switch volta-cli to actions/setup-node for CI * regenerate yarn.lock * jest maxWorkers 150 * Revert "jest maxWorkers 150" This reverts commit 963257f. * jest debug detectOpenHandles * jest maxConcurrency 1 * Revert "jest maxConcurrency 1" This reverts commit 08b44c3. * jest no transform * add babel for jest * Revert "jest no transform" This reverts commit 22637bc. * jest verbose * Revert "add babel for jest" This reverts commit b7daa1f. * Revert "jest verbose" This reverts commit f2a5ddc. * Revert "jest debug detectOpenHandles" This reverts commit d5cc369. * disable broken test file in older versions of Node * Revert "regenerate yarn.lock" This reverts commit ef5befc. * Revert "switch volta-cli to actions/setup-node for CI" This reverts commit f33308a. * improve comments * fix URL path for windows * unicorn/prefer-module lint rule already enabled so remove redundant line * improve comments * raise test coverage percentages back up * fix test coverage percentage * fix comment * chore(deps): update find-up to v6 * chore(deps): update get-stdin to v9 * chore(deps): update execa to v6 * chore(deps): update globby to v6 * docs: add v4 migration guide * Release 4.0.0-beta.2 * Improve v4 migration guide (#2302) * Fix false positives with non-serializable rule configs in duplicate test case check (#2301) * deps: Update @lint-todos/utils to fix bug with non-normalized paths * Fixing timeout in todo tests * Tweak ordering of items in v4 migration guide (#2304) * Release 4.0.0-beta.3 * docs: add migration guide link * Remove `no-model-argument-in-route-templates` rule from `recommended` config (#2315) * Remove `no-dynamic-subexpression-invocations` rule from `recommended` config (#2308) Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com> * Remove `no-mut-helper` rule from `recommended` config (#2316) * Update dependencies (#2317) * also skip test/acceptance/public-api-test.js in Node 12/14 CI due to ESM import issue * fix ignore test CLI option * fix jest test coverage percentage for Node 12/14 since some test files aren't running there * increase CI timeout since Windows test take a long time Co-authored-by: Bert De Block <bert.deblock@bagaar.be> Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com> Co-authored-by: Steve Calvert <scalvert@linkedin.com> Co-authored-by: Robert Jackson <me@rwjblue.com> Co-authored-by: Aaron Sikes <aaron@sikes.io> Co-authored-by: Steve Calvert <steve.calvert@gmail.com> Co-authored-by: Sam Van Campenhout <sam.van.campenhout@gmail.com> Co-authored-by: NullVoxPopuli <LPSego3+dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put more important items that affect lots of users first.
Follow-up to: